fix(watch): catch error from returned promise

vuejs · Sep 19, 2024 · 65e6a10 · 65e6a10
1 parent c118104
commit 65e6a10
Showing 1 changed file with 14 additions and 10 deletions.
diff --git a/packages/reactivity/src/watch.ts b/packages/reactivity/src/watch.ts
@@ -199,11 +199,13 @@ export function watch(
           if (isFunction(maybeCleanup)) {
             boundCleanup(maybeCleanup)
           } else if (isPromise(maybeCleanup)) {
-            maybeCleanup.then(cleanup => {
-              if (isFunction(cleanup)) {
-                boundCleanup(cleanup)
-              }
-            })
+            maybeCleanup
+              .then(cleanup => {
+                if (isFunction(cleanup)) {
+                  boundCleanup(cleanup)
+                }
+              })
+              .catch(NOOP)
           }
         } finally {
           activeWatcher = currentEffect
@@ -282,11 +284,13 @@ export function watch(
           if (isFunction(maybeCleanup)) {
             boundCleanup(maybeCleanup)
           } else if (isPromise(maybeCleanup)) {
-            maybeCleanup.then(cleanup => {
-              if (isFunction(cleanup)) {
-                boundCleanup(cleanup)
-              }
-            })
+            maybeCleanup
+              .then(cleanup => {
+                if (isFunction(cleanup)) {
+                  boundCleanup(cleanup)
+                }
+              })
+              .catch(NOOP)
           }
           oldValue = newValue
         } finally {