Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing colon in event name for dynamic model arguments #642

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

KaelWD
Copy link
Contributor

@KaelWD KaelWD commented May 15, 2023

🤔 What is the nature of this change?

  • New feature
  • Fix bug
  • Style optimization
  • Code style optimization
  • Performance optimization
  • Build optimization
  • Refactor code or style
  • Test related
  • Other

🔗 Related Issue

fixes #602
fixes #679

💡 Background or solution

https://vue-jsx-explorer.netlify.app/#const%20v%20%3D%20(%3C%3E%0A%20%20%3CMyComp%20v-model%3Atitle%3D%7B%20title.value%20%7D%3E%3C%2FMyComp%3E%0A%20%20%3CMyComp%20v-model%3D%7B%20%5Btitle.value%2C%20'title'%5D%7D%3E%3C%2FMyComp%3E%0A%20%20%3CMyComp%20v-model%3D%7B%20%5Btitle.value%2C%20key%5D%7D%3E%3C%2FMyComp%3E%0A%3C%2F%3E)%0A

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for vue-jsx-explorer failed.

Name Link
🔨 Latest commit 96e5ce3
🔍 Latest deploy log https://app.netlify.com/sites/vue-jsx-explorer/deploys/6461f9e18714120008d19453

@luocong2016
Copy link

@KaelWD @cexbrayat @Jinjiang @kazupon @FloEdelmann

@sxzz sxzz force-pushed the fix/602-dynamic-model-argument branch from 96e5ce3 to 33f5fcc Compare September 11, 2024 11:20
Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for vue-jsx-explorer ready!

Name Link
🔨 Latest commit 33f5fcc
🔍 Latest deploy log https://app.netlify.com/sites/vue-jsx-explorer/deploys/66e17cf7d3e9e400080b9683
😎 Deploy Preview https://deploy-preview-642--vue-jsx-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sxzz sxzz changed the title fix: add colon in event name for dynamic model arguments fix: missing colon in event name for dynamic model arguments Sep 11, 2024
@sxzz sxzz merged commit ad14b2d into vuejs:main Sep 11, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vModel 修饰符不能动态 [BUG] v-model arguments is not work in tsx
3 participants