Simplify module evaluation #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put all expressions in a single vec, so that it can be evaluated on its own, before evaluating the module operations. This will allow cleaning the code in the next commits are removing some Arc.
Those were needed to fix ownership issues when evaluating module values with operations chains. This has been fixed by moving the evaluation of the expressions used in operations outside of the evaluation of those operations.
vthib
force-pushed
the
simplify-module-evaluation
branch
from
19d74c9
to
63cdd74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework how module values are evaluated to simplify some code, and remove the use of Arc to wrap module values.