Add bytes intern pool to reduce memory consumption #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to allocate a string for this key.
Those types will change from boreal-parser so copy them internally beforehand.
Add a bytes pool object to use a single allocation to store all bytes used in rule metadatas.
Add a map on top of the bytes pool to avoid storing the same string multiple times. This is extremely useful for metadata keys, which tends to always be the same in a set of rules.
Repository owner
deleted a comment from
codecov-commenter
Jul 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
========================================
Coverage 98.60% 98.60%
========================================
Files 79 80 +1
Lines 24364 24471 +107
========================================
+ Hits 24023 24130 +107
Misses 341 341 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intern literal bytes in a pool to reduce the memory it takes in compiled rules. This is used for literals in conditions, but mainly for metadata keys and values.
For example, the icewater ruleset have a lot of metadata for each rule, which always the same names. With this optimization, the memory consumption of the icewater compiled rules goes from 76MB to 62MB.