use simplfied Bitmap #120
Merged
use simplfied Bitmap #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
March 4, 2024 16:55
Replace `bitmaps::Bitmap` with a simplified bitmap implementation for the 256 wide use case needed by boreal. This does a few things: * Provide a simplified interface for Bitmap based on what's used by boreal * Replaces a bunch of casts & slice indexing that could cause future issues with compile-time validation (by moving from indexing into the Bitmap by usize to u8) * Removes a MPL2 licensed dependency (which can be incompatible with
|
note: the coverage task is currently failing due to issues addressed in #122. |
|
Sorry about all the CI issues. I wouldn't mind removing a dependency, especially as we only use the 256 sized bitmap, so making a simple, custom impl makes sense. I'll try to review this before the end of the week |
vthib
requested changes
Mar 9, 2024
|
@vthib I've applied your suggestions. |
vthib
approved these changes
Mar 10, 2024
|
@demoray approved, but needs a rebase, probably after the merges of the nightly fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
bitmaps::Bitmapwith a simplified bitmap implementation for the 256 wide use case needed by boreal.This does a few things: