Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/underlined links #50

Closed
wants to merge 5 commits into from
Closed

Feat/underlined links #50

wants to merge 5 commits into from

Conversation

phvm
Copy link
Contributor

@phvm phvm commented May 16, 2024

What is the purpose of this pull request?

Change some link to have a underline

What problem is this solving?

This solves a accessibility problem for color blind users who cannot identify properly some links

How should this be manually tested?

Open the running app and see that some links now have a underline

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@phvm phvm added the release-minor Minor version bump label May 16, 2024
Copy link

netlify bot commented May 16, 2024

Deploy Preview for leafy-mooncake-7c2e5e ready!

Name Link
🔨 Latest commit 7910524
🔍 Latest deploy log https://app.netlify.com/sites/leafy-mooncake-7c2e5e/deploys/66464b0e60b29200086c6def
😎 Deploy Preview https://deploy-preview-50--leafy-mooncake-7c2e5e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@phvm phvm changed the title Feat/underlined links Feat: underlined links May 16, 2024
@phvm phvm changed the title Feat: underlined links feat/underlined links May 16, 2024
@phvm phvm changed the title feat/underlined links Feat/underlined links May 16, 2024
@phvm phvm linked an issue May 16, 2024 that may be closed by this pull request
@phvm phvm closed this Jun 11, 2024
@phvm phvm deleted the feat/underlined_links branch June 11, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-minor Minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant