Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: localized slugs build #117

Merged
merged 6 commits into from
Oct 16, 2024
Merged

fix: localized slugs build #117

merged 6 commits into from
Oct 16, 2024

Conversation

julia-rabello
Copy link
Contributor

@julia-rabello julia-rabello commented Oct 15, 2024 •
edited
Loading

What is the purpose of this pull request?

  • rollback changes in package.json from feat/localized slugs #110 to make netlify build initialize correctly again
  • fix parentsArray serialization error during build
  • use GetServerSideProps for tutorials and tracks

What problem is this solving?

How should this be manually tested?

Screenshots or example usage

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@netlify Netlify
Copy link

netlify bot commented Oct 15, 2024 •
edited
Loading

❌ Deploy Preview for leafy-mooncake-7c2e5e failed.

Name Link
🔨 Latest commit c13e57f
🔍 Latest deploy log https://app.netlify.com/sites/leafy-mooncake-7c2e5e/deploys/670eb1b24f8b4600083ba794

@julia-rabello julia-rabello added the release-no No release bump label Oct 15, 2024
@julia-rabello julia-rabello added release-patch Patch version bump and removed release-no No release bump labels Oct 15, 2024
@julia-rabello julia-rabello self-assigned this Oct 15, 2024
@julia-rabello julia-rabello marked this pull request as ready for review October 15, 2024 14:59
@julia-rabello julia-rabello changed the title fix: rollback package.json fix: localized slugs build Oct 15, 2024
PedroAntunesCosta
PedroAntunesCosta approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@PedroAntunesCosta PedroAntunesCosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@julia-rabello julia-rabello merged commit f24ec1e into main Oct 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@PedroAntunesCosta PedroAntunesCosta PedroAntunesCosta approved these changes

Assignees

@julia-rabello julia-rabello

Labels
release-patch Patch version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julia-rabello @PedroAntunesCosta