-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed the log and the package.json in order to add the new faststor… #1119
base: 2.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a link
command... How is this going to work?
@valentino-amadeus I was able to change the implementation of my plugin so that all the commands will fall under the "faststore" namespace. For example, to run my link command, you would use I was following an older version of instructions on how to implement a plugin. As far as I understand, with the newer version of toolbelt, you are able to search and install plugins that have the repository name "@vtex/cli-plugin-somehtingelse" right? In that case, there is no need for me to include my plugin as the dependency for this project? If this is truly the case then I can just close this pull request. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valentino-amadeus I was able to change the implementation of my plugin so that all the commands will fall under the "faststore" namespace. For example, to run my link command, you would use vtex faststore link.
Nice!
you are able to search and install plugins that have the repository name "@vtex/cli-plugin-somehtingelse" right?
You can search the plugins in npm
(is there another way? 👀) and install them from there.
there is no need for me to include my plugin as the dependency for this project?
There is no need, but if you choose not to do so, you may want to include this information in the (fastsore's?) documentation.
In case you choose to include this plugin as a dependency, it would be nice to update the commands list.
### added | ||
- [vtex faststore-cli] adding a new plugin called faststore-cli that facilitate linking for the faststore framework |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### added | |
- [vtex faststore-cli] adding a new plugin called faststore-cli that facilitate linking for the faststore framework | |
### Added | |
- [vtex faststore-cli] Add `cli-plugin-faststore` plugin, that facilitates linking for the faststore framework |
…e-cli plugin
What is the purpose of this pull request?
I am a winter intern and I developed a CLI plugin to facilitate the file linking process in the faststore framework. I was asked to integrate this plugin with Toolbelt.
What problem is this solving?
Adding the @vtex/faststore-cli to the dependencies so we can use this plugin
How should this be manually tested?
Run the faststore-cli commands on toolbelt
Screenshots or example usage
please refer to the readme file in @vtex/faststore-cli
Types of changes
Chores checklist
CHANGELOG.md