@auth: Validate token's account
scope
#563
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Check whether the token's indicated account is the request's context account.
What problem is this solving?
Until now, the @auth logic allows for cross-account requests as long as the target account contains the user that is identified by the token. This is not usually a problem since the token has to be a valid VTEX ID token and the user mail has to have the necessary access scope in the target account in order for this to work. However, it is a conceptual error (and a security flaw) to allow for cross-account requests in this manner unless the resource is explicitly allowed by a ReBAc rule, which is not the case here (GraphQL fields are not ReBAc-sensitive in VTEX IO).
How should this be manually tested?
vtexgame1
, but in a different account;Use that token to make the following request:
You should get an 200 response but with an error body like the one below:
Screenshots or example usage
Types of changes