Avoid using async/await with then callbacks

vtex · Oct 23, 2024 · 1c052c4 · 1c052c4
1 parent 2c299e3
commit 1c052c4
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/src/utils/MineWinsConflictsResolver.ts b/src/utils/MineWinsConflictsResolver.ts
@@ -49,18 +49,17 @@ export class MineWinsConflictsResolver<T> implements ConflictsResolver<T> {
   }
 
   public async resolveAll() {
-    return await this.client.getConflicts<AxiosResponse<VBaseConflictData[]>>(this.bucket).then((data) => {
-      const { data: conflicts }: { data: VBaseConflictData[] } = data
-
-      const resolved = conflicts.map((conflict) => {
-        conflict.base.parsedContent = this.parseConflict(conflict.base)
-        conflict.master.parsedContent = this.parseConflict(conflict.master)
-        conflict.mine.parsedContent = this.parseConflict(conflict.mine)
-        return this.resolveConflictMineWins(conflict)
-      })
-
-      return resolved as any
+    const conflictsResponse = await this.client.getConflicts<AxiosResponse<VBaseConflictData[]>>(this.bucket)
+    const { data: conflicts }: { data: VBaseConflictData[] } = conflictsResponse
+
+    const resolvedConflicts = conflicts.map((conflict) => {
+      conflict.base.parsedContent = this.parseConflict(conflict.base)
+      conflict.master.parsedContent = this.parseConflict(conflict.master)
+      conflict.mine.parsedContent = this.parseConflict(conflict.mine)
+      return this.resolveConflictMineWins(conflict)
     })
+
+    return resolvedConflicts
   }
 
   protected mergeMineWins(base: Configuration, master: Configuration, mine: Configuration) {