fix: Consider shouldSplitItem value from ValidateCart mutation response
#2528
+22
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lucasfp13
added
the
don't merge
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
lucasfp13
force-pushed
the
fix/consider-should-split-item-from-mutation-response
branch
from
e0da991
to
325e02e
Compare
lucasfp13
changed the title
shouldSplitItem from ValidateCart mutation responseshouldSplitItem value from ValidateCart mutation response
lucasfp13
added
bug
lucasfp13
requested review from
emersonlaurentino,
renatamottam,
hellofanny,
eduardoformiga and
pedromtec
and removed request for
a team,
emersonlaurentino and
renatamottam
hellofanny
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
LGTM 🚀
I've tested in the starter: vtex-sites/starter.store#600
The shouldSplitItem variable is being sent on the payload as expected ✅
| discovery.config.js | payload |
|---|---|
 |
 |
after cleaning the cache,I've tried setting shouldSplitItem: false
| discovery.config.js | payload |
|---|---|
 |
 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR intends to fix the behavior of
shouldSplitItemvalue sent by through theValidateCartmutation.Currently, the variable value is being overridden after some mutation calls due to its value not being sent back in the mutation response, so with these changes we will consider the same value set in the store config.
How to test it?
Perform actions that triggers the
ValidateCartmutation (open/close the cart, add/remove items to/from the cart) and check if theshouldSplitItemvariable is being sent on the payload and if its value is corresponding to the one set in the store config.Starters Deploy Preview
References
Issue: #2426