Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Belgium country rules #548

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Fix Belgium country rules #548

merged 1 commit into from
Dec 6, 2023

Conversation

sheilagomes
Copy link
Contributor

@sheilagomes sheilagomes commented Nov 17, 2023 •
edited
Loading

Fix Belgium country rules to hide department field and include number field. Tracked in task LOC-12820.

How should this be manually tested?

https://sheilavtex--motorolabenl.myvtex.com/checkout/#/shipping

Screenshots or example usage

Before:
Pasted image 20231117105827
After:
Pasted image 20231117111323

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@vtex-io-ci-cd VTEX IO CI/CD
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 17, 2023 •
edited by sheilagomes
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@sheilagomes sheilagomes marked this pull request as ready for review November 17, 2023 14:17
@sheilagomes sheilagomes requested a review from a team as a code owner November 17, 2023 14:17
kaio-donadelli
kaio-donadelli approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@kaio-donadelli kaio-donadelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sheilagomes sheilagomes merged commit d81a616 into main Dec 6, 2023
53 of 54 checks passed
@sheilagomes sheilagomes deleted the fix/bel-country-rules branch December 6, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evertonstrack evertonstrack evertonstrack approved these changes

@kaio-donadelli kaio-donadelli kaio-donadelli approved these changes

@thiagobaranda thiagobaranda Awaiting requested review from thiagobaranda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheilagomes @evertonstrack @kaio-donadelli