Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NZL geolocation neighborhood comma #545

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Fix NZL geolocation neighborhood comma #545

merged 2 commits into from
Oct 17, 2023
+14 −3

Conversation

sheilagomes
Copy link
Contributor

@sheilagomes sheilagomes commented Oct 13, 2023 •
edited by jira bot
Loading

Fix to complement this PR, adding a comma for New Zealand geolocation between the address and the neighborhood. Tracked in task LOC-12478.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@sheilagomes sheilagomes requested a review from a team as a code owner October 13, 2023 13:23
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 13, 2023 •
edited by sheilagomes
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@sheilagomes sheilagomes merged commit 14f67cb into main Oct 17, 2023
24 of 25 checks passed
@sheilagomes sheilagomes deleted the fix/NZL-neighborhood branch October 17, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmarcosp vmarcosp vmarcosp approved these changes

@jeffersontuc jeffersontuc Awaiting requested review from jeffersontuc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheilagomes @vmarcosp