Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NLD.ts Number Not Mandatory #542

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Update NLD.ts Number Not Mandatory #542

merged 1 commit into from
Oct 13, 2023

Conversation

lrodriguess
Copy link
Contributor

@lrodriguess lrodriguess commented Oct 12, 2023 •
edited by kaio-donadelli
Loading

What is the purpose of this pull request?

What problem is this solving?

How should this be manually tested?

Screenshots or example usage

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@lrodriguess lrodriguess requested a review from a team as a code owner October 12, 2023 15:04
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 12, 2023 •
edited by lrodriguess
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

kaio-donadelli
kaio-donadelli approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@kaio-donadelli kaio-donadelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaio-donadelli kaio-donadelli merged commit ea9e13b into main Oct 13, 2023
54 checks passed
@kaio-donadelli kaio-donadelli deleted the lrodriguess-NL-number-notmandatory branch October 13, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaio-donadelli kaio-donadelli kaio-donadelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lrodriguess @kaio-donadelli