Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: discount not being sent in view_item #584

Merged
merged 6 commits into from
May 22, 2024
Merged

fix: discount not being sent in view_item #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2a31a96
fix: discount not being send in view_item
iago1501 May 14, 2024
c4b61d7
fix: discount not being sent in view_item
iago1501 May 14, 2024
a59241f
Update ProductTitleAndPixel.tsx
iago1501 May 20, 2024
73d3e2d
Update ProductTitleAndPixel.tsx
iago1501 May 20, 2024
108281c
PriceWithoutDiscount is the same of Price when no results
iago1501 May 20, 2024
045c0dc
Update ProductTitleAndPixel.tsx
iago1501 May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

### Added
- `PriceWithoutDiscount` in productViewEvent

## [2.135.0] - 2024-03-07

### Changed
Expand Down
4 changes: 4 additions & 0 deletions react/components/ProductTitleAndPixel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ interface CommertialOffer {
ListPrice: number
Price: number
AvailableQuantity: number
PriceWithoutDiscount: number
}

type MaybeProduct = Product | null
Expand Down Expand Up @@ -123,6 +124,9 @@ function getSkuProperties(item: SKU): SKUEvent {
Price: seller.commertialOffer.Price,
ListPrice: seller.commertialOffer.ListPrice,
AvailableQuantity: seller.commertialOffer.AvailableQuantity,
PriceWithoutDiscount:
seller.commertialOffer?.PriceWithoutDiscount ||
seller.commertialOffer.Price,
},
})),
}
Expand Down
Loading