Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add zIndex property #78

Merged
merged 3 commits into from
Nov 1, 2024
Merged

feat: add zIndex property #78

merged 3 commits into from
Nov 1, 2024

Conversation

ArthurFerrao
Copy link
Contributor

What problem is this solving?

We have a situation where more than one Drawer needs to be opened and we need to be able to define which one is on top.

How to test it?

Workspace

Screenshots or example usage:

Gravacao.de.Tela.2024-10-29.as.18.03.47.mov

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@ArthurFerrao ArthurFerrao added the enhancement New feature or request label Oct 30, 2024
@ArthurFerrao ArthurFerrao self-assigned this Oct 30, 2024
@ArthurFerrao ArthurFerrao requested a review from a team as a code owner October 30, 2024 13:27
@ArthurFerrao ArthurFerrao requested review from gabpaladino, vsseixaso and leo-prange-vtex and removed request for a team October 30, 2024 13:27
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 30, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Oct 30, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@iago1501 iago1501 requested review from iago1501 and removed request for gabpaladino, vsseixaso and leo-prange-vtex October 30, 2024 18:42
Copy link
Contributor

@iago1501 iago1501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArthurFerrao ArthurFerrao merged commit 17f4dca into master Nov 1, 2024
9 checks passed
@ArthurFerrao ArthurFerrao deleted the feat/add-zindex-prop branch November 1, 2024 14:48
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 1, 2024

Your PR has been merged! App is being published. 🚀
Version 0.17.2 → 0.18.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

@germanBonacchi
Copy link

Hi @ArthurFerrao, @hiagolcm and @iago1501,

This weekend, we encountered an issue with one of our clients due to this change.

The native minicart component relies on vtex.store-drawer, and this update introduced an inline z-index style with a default value of 999. This conflicted with our existing styles, which apply a different z-index without !important, causing display issues that prevented users from advancing beyond the minicart.

As a result, our client experienced a half-day of lost sales due to this unexpected conflict.

To prevent similar issues in the future, we kindly ask that changes be properly announced in advance, for example, in VTEX release notes. Having prior knowledge of these updates would allow us to prepare and adapt our clients' stores to avoid potential revenue loss.

Thank you for your attention to this matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants