New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arguments to atan2 are reversed #127

Open

aletheos opened this issue Apr 7, 2022 · 1 comment

aletheos commented Apr 7, 2022

hump/vector.lua

Line 118 in 08937cc

return new(atan2(self.x, self.y), self:len())

Typically the arguments to atan2 are y first, and that is how it's done in the corresponding function in vector-light, so I assume this is a mistake.

HDictus commented Apr 8, 2022

Hey aletheos, vrld isn't maintaining this anymore. I'm taking care of their repo here: https://github.com/HDictus/hump/

This does look like a mistake, though I'm surprised no issue has come up before with users of hump.vector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment