Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.0.0 #188

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Release 5.0.0 #188

merged 2 commits into from
Jul 8, 2024

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak
Copy link
Member Author

I would like to include #189 as well

@bastelfreak bastelfreak force-pushed the rel500 branch 3 times, most recently from 3074366 to c2141d9 Compare June 26, 2024 20:20
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggestion assumes #189 is merged, but I'm a bit hesitant on that. I'd prefer to formally deprecate it first.

That means:

  • Make sure the configuration option to switch is well documented
  • Migration guide
  • Announce the next major version will drop it
  • Communicate this (also to PDK users)

CHANGELOG.md Outdated Show resolved Hide resolved
@bastelfreak
Copy link
Member Author

bastelfreak commented Jun 28, 2024

  • I raised Deprecate symbolized facts #193 which updates the README.md and deprecates symbolized facts
  • I updated the release notes for 3.0.0 (release notes for 3.0.0 #170), say mentioned that symbolized keys are deprecated with the 5.0.0 release
  • I moved 6.0.0 release summary #190 to the release summary for 6.0.0
  • I don't think that we need another release summary for 5.0.0. But if someone has a different opinion we can add it.
  • I communicated the change to the CAT/DevX team

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.06%. Comparing base (50cff16) to head (60e902c).
Report is 12 commits behind head on master.

Current head 60e902c differs from pull request most recent head a0ac683

Please upload reports for the commit a0ac683 to get more accurate results.

Files Patch % Lines
lib/rspec-puppet-facts/version.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   94.93%   95.06%   +0.12%     
==========================================
  Files           2        2              
  Lines         158      162       +4     
==========================================
+ Hits          150      154       +4     
  Misses          8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bastelfreak bastelfreak force-pushed the rel500 branch 2 times, most recently from 0b2587d to a0ac683 Compare June 28, 2024 17:11
@bastelfreak bastelfreak merged commit 56c2f65 into voxpupuli:master Jul 8, 2024
7 checks passed
@bastelfreak bastelfreak deleted the rel500 branch July 8, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants