-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.0.0 #188
Release 5.0.0 #188
Conversation
I would like to include #189 as well |
3074366
to
c2141d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This suggestion assumes #189 is merged, but I'm a bit hesitant on that. I'd prefer to formally deprecate it first.
That means:
- Make sure the configuration option to switch is well documented
- Migration guide
- Announce the next major version will drop it
- Communicate this (also to PDK users)
8684758
to
60e902c
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
==========================================
+ Coverage 94.93% 95.06% +0.12%
==========================================
Files 2 2
Lines 158 162 +4
==========================================
+ Hits 150 154 +4
Misses 8 8 ☔ View full report in Codecov by Sentry. |
0b2587d
to
a0ac683
Compare
No description provided.