Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not query for the exact facter version #151

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Do not query for the exact facter version #151

merged 1 commit into from
Jul 20, 2023

Commits on Jul 6, 2023

  1. Do not query for the exact facter version 

    This assumes that no exact match can be found in most cases. This saves
a call to FacterDB. Some testing on puppet-nginx this reduced the time
for a dry run by about 1 to 2 seconds, from about ~11 to ~9 seconds.

Implementation wise this switches to using Gem::Requirement to detect
matching versions. This means you can also specify `~> 3.8` as a valid
facterversion, or `>= 3 < 5`.
    @ekohl
    ekohl committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    d690765 View commit details
    Browse the repository at this point in the history