Merge pull request #181 from ekohl/use-max_by

Use max_by to determine the maximum value
voxpupuli · Jun 9, 2024 · bf7b684 · bf7b684
2 parents 50cff16 + a3c9b6b
commit bf7b684
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/rspec-puppet-facts.rb b/lib/rspec-puppet-facts.rb
@@ -405,7 +405,7 @@ def self.facter_version_for_puppet_version(puppet_version)
       return Facter.version
     end
 
-    applicable_versions.sort { |a, b| b.first <=> a.first }.first.last
+    applicable_versions.max_by { |p, _| p }.last
   rescue JSON::ParserError
     warning "#{json_path} contains invalid JSON, defaulting to Facter #{Facter.version}"
     Facter.version