Skip to content

Commit

Permalink
Merge pull request #149 from bastelfreak/ruby25
Browse files Browse the repository at this point in the history
Drop Ruby 2.4/2.5/2.6 support
  • Loading branch information
ekohl authored Jul 6, 2023
2 parents 0921dff + 0857fbf commit 59c37ef
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 14 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ jobs:
fail-fast: false
matrix:
include:
- ruby: '2.4'
- ruby: '2.5'
- ruby: '2.6'
- ruby: '2.7'
- ruby: '3.0'
- ruby: '3.1'
Expand Down
8 changes: 7 additions & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,13 @@ require:

AllCops:
NewCops: enable
TargetRubyVersion: '2.4'
TargetRubyVersion: '2.7'

Gemspec/DevelopmentDependencies:
Enabled: false

Gemspec/RequireMFA:
Enabled: false

Style/TrailingCommaInHashLiteral:
Enabled: True
Expand Down
20 changes: 14 additions & 6 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,19 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2023-03-17 10:58:25 UTC using RuboCop version 1.12.1.
# on 2023-03-17 11:50:22 UTC using RuboCop version 1.48.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 1
# This cop supports unsafe autocorrection (--autocorrect-all).
Performance/MapCompact:
Exclude:
- 'lib/rspec-puppet-facts.rb'

# Offense count: 32
# Configuration parameters: Prefixes.
# Configuration parameters: Prefixes, AllowedPatterns.
# Prefixes: when, with, without
RSpec/ContextWording:
Exclude:
Expand All @@ -24,9 +30,9 @@ RSpec/ExpectInHook:
- 'spec/rspec_puppet_facts_spec.rb'

# Offense count: 20
# Cop supports --auto-correct.
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle.
# SupportedStyles: single_line_only, single_statement_only, disallow
# SupportedStyles: single_line_only, single_statement_only, disallow, require_implicit
RSpec/ImplicitSubject:
Exclude:
- 'spec/rspec_puppet_facts_spec.rb'
Expand All @@ -47,12 +53,14 @@ RSpec/MultipleExpectations:
Max: 2

# Offense count: 46
# Configuration parameters: IgnoreSharedExamples.
# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
# SupportedStyles: always, named_only
RSpec/NamedSubject:
Exclude:
- 'spec/rspec_puppet_facts_spec.rb'

# Offense count: 14
# Configuration parameters: AllowedGroups.
RSpec/NestedGroups:
Max: 6

Expand All @@ -62,7 +70,7 @@ RSpec/StubbedMock:
- 'spec/rspec_puppet_facts_spec.rb'

# Offense count: 2
# Cop supports --auto-correct.
# This cop supports safe autocorrection (--autocorrect).
Rake/Desc:
Exclude:
- 'Rakefile'
6 changes: 2 additions & 4 deletions rspec-puppet-facts.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,17 @@ Gem::Specification.new do |s|
s.description = 'Contains facts from many Facter version on many Operating Systems'
s.licenses = 'Apache-2.0'

# see .travis.yml for the supported ruby versions
s.required_ruby_version = '>= 2.4.0'
s.required_ruby_version = '>= 2.7.0'

s.files = `git ls-files`.split("\n")
s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n")
s.executables = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }

s.add_development_dependency 'mime-types'
s.add_development_dependency 'rake'
s.add_development_dependency 'rspec'
s.add_development_dependency 'yard'

s.add_development_dependency 'rubocop', '~> 1.12.0'
s.add_development_dependency 'rubocop', '~> 1.48.1'
s.add_development_dependency 'rubocop-performance'
s.add_development_dependency 'rubocop-rake'
s.add_development_dependency 'rubocop-rspec'
Expand Down

0 comments on commit 59c37ef

Please sign in to comment.