Skip to content

Commit

Permalink
Merge pull request #165 from bastelfreak/foo3
Browse files Browse the repository at this point in the history
gemspec: Add version constraints & CI: Build gem in strict mode
  • Loading branch information
bastelfreak authored Jan 30, 2024
2 parents c7dbd2c + 8dc92a5 commit 1c2e140
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
env:
BUNDLE_WITHOUT: release
- name: Build gem
run: gem build *.gemspec
run: gem build --strict --verbose *.gemspec
- name: Publish gem to rubygems.org
run: gem push *.gem
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
- name: Test against Puppet component versions
run: bundle exec rake puppet_versions:test
- name: Test gem build
run: bundle exec rake build
run: gem build --strict --verbose *.gemspec

tests:
needs:
Expand Down
2 changes: 0 additions & 2 deletions Rakefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require 'bundler/gem_tasks'

PUPPET_VERSIONS_PATH = File.join(__dir__, 'ext', 'puppet_agent_components.json')

begin
Expand Down
14 changes: 7 additions & 7 deletions rspec-puppet-facts.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ Gem::Specification.new do |s|
s.files = `git ls-files`.split("\n")
s.executables = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }

s.add_development_dependency 'mime-types'
s.add_development_dependency 'rake'
s.add_development_dependency 'rspec'
s.add_development_dependency 'yard'
s.add_development_dependency 'mime-types', '~> 3.5', '>= 3.5.2'
s.add_development_dependency 'rake', '~> 13.1'
s.add_development_dependency 'rspec', '~> 3.12'
s.add_development_dependency 'yard', '~> 0.9.34'

s.add_development_dependency 'voxpupuli-rubocop', '~> 2.4.0'

s.add_runtime_dependency 'facter'
s.add_runtime_dependency 'facterdb', '>= 0.5.0'
s.add_runtime_dependency 'puppet'
s.add_runtime_dependency 'facter', '< 5'
s.add_runtime_dependency 'facterdb', '>= 0.5.0', '< 2'
s.add_runtime_dependency 'puppet', '>= 7', '< 9'
end

0 comments on commit 1c2e140

Please sign in to comment.