Support OpenSSL 3 #223
Merged
Support OpenSSL 3 #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
In OpenSSL 3 the OpenSSL::PKey::EC class has become immutable. In a pure OpenSSL 3 world the right thing would be to use OpenSSL::PKey.generate_key but that's not supported in OpenSSL 1. Calling .generate is compatible with both 1 and 3. It also stops mocking the actual calls to see if they will work. prime239v1 is replaced by prime256v1 because on Fedora 39+ only the latter is available.
bastelfreak
force-pushed
the
openssl-3-support
branch
from
f2e6c7f
to
92bf1e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OpenSSL 3 the
OpenSSL::PKey::ECclass has become immutable. In a pure OpenSSL 3 world the right thing would be to useOpenSSL::PKey.generate_keybut that's not supported in OpenSSL 1. Calling.generateis compatible with both 1 and 3.It also stops mocking the actual calls to see if they will work. prime239v1 is replaced by prime256v1 because on Fedora 39+ only the latter is available.
I only tested this locally on my desktop. If it passes, it's a pure enhancement and I'd expect make Puppet 8 support possible.