Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OpenSSL::PKey.read to read private keys #190

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Use OpenSSL::PKey.read to read private keys #190

merged 4 commits into from
Jul 18, 2024

Commits on Jul 18, 2024

  1. Fix RSpec/AnyInstance disable

    @ekohl
    ekohl committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    89861bd View commit details
    Browse the repository at this point in the history

  2. Correct file mocks in tests 

    In 7285844 the method was changed from
File.open to File.write, but the mocks weren't modified. This changes
from allow to expect so that if it's refactored, it will fail the tests.

Fixes: 7285844 ("Auto-correct rubocop offenses")
    @ekohl
    ekohl committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    f0ea013 View commit details
    Browse the repository at this point in the history

  3. Change allow() to expect() in openssl_spec 

    This makes the mocking stronger because tests will fail if they aren't
called in a certain way.
    @ekohl
    ekohl committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ff88d72 View commit details
    Browse the repository at this point in the history

  4. Use OpenSSL::PKey.read to read private keys 

    This utilizes a method where OpenSSL itself determines the encryption
type rather than a static parameter. This is more flexible because it
requires fewer parameters to be specified.
    @ekohl
    ekohl committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    cd97808 View commit details
    Browse the repository at this point in the history