Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require puppetlabs-stdlib 9.x #165

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Require puppetlabs-stdlib 9.x #165

merged 1 commit into from
Jun 24, 2023

Conversation

smortex
Copy link
Member

@smortex smortex commented Jun 14, 2023 •
edited
Loading

  • Require puppetlabs-stdlib 9.x

@smortex smortex added the enhancement New feature or request label Jun 14, 2023
zilchms
zilchms approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@zilchms zilchms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bastelfreak
Copy link
Member

I am wondering if we should update

puppet-openssl/manifests/packages.pp

Line 13 in 8675b7c

ensure_packages(['ca-certificates'], { ensure => $openssl::ca_certificates_ensure, })
for stdliv::ensure_packages and switch the pr title to "require stdlib 9". we did that on other modules as well

@zilchms
Copy link
Contributor

zilchms commented Jun 19, 2023

thats a good point, this module needs a major release anyway with all the changes that came in

@smortex smortex changed the title Relax dependencies version requirements Require dependencies version requirements Jun 24, 2023
@smortex smortex changed the title Require dependencies version requirements Require puppetlabs-stdlib 9.x Jun 24, 2023
@smortex smortex added backwards-incompatible and removed enhancement New feature or request labels Jun 24, 2023
@smortex smortex requested a review from zilchms June 24, 2023 20:33
@bastelfreak bastelfreak merged commit 1b6ae9a into master Jun 24, 2023
3 checks passed
@bastelfreak bastelfreak deleted the relax-dependencies branch June 24, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

@zilchms zilchms Awaiting requested review from zilchms

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smortex @bastelfreak @zilchms