fix: use shellquote instead of single quotes

voxpupuli · Jul 9, 2024 · 17d73f4 · 17d73f4
1 parent f2d40e4
commit 17d73f4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/manifests/export/pem_cert.pp b/manifests/export/pem_cert.pp
@@ -42,7 +42,7 @@
 
   $passin_opt = $in_pass ? {
     undef   => '',
-    default => "-nokeys -passin pass:'${in_pass}'",
+    default => "-nokeys -passin pass:${shellquote($in_pass)}",
   }
 
   if $ensure == 'present' {

diff --git a/manifests/export/pem_key.pp b/manifests/export/pem_key.pp
@@ -21,12 +21,12 @@
   if $ensure == 'present' {
     $passin_opt = $in_pass ? {
       undef   => '',
-      default => "-passin pass:${in_pass}",
+      default => "-passin pass:${shellquote($in_pass)}",
     }
 
     $passout_opt = $out_pass ? {
       undef   => '-nodes',
-      default => "-passout pass:${out_pass}",
+      default => "-passout pass:${shellquote($out_pass)}",
     }
 
     $cmd = [

diff --git a/manifests/export/pkcs12.pp b/manifests/export/pkcs12.pp
@@ -27,12 +27,12 @@
   if $ensure == 'present' {
     $pass_opt = $in_pass ? {
       undef   => '',
-      default => "-passin pass:${in_pass}",
+      default => "-passin pass:${shellquote($in_pass)}",
     }
 
     $passout_opt = $out_pass ? {
       undef   => '',
-      default => "-passout pass:${out_pass}",
+      default => "-passout pass:${shellquote($out_pass)}",
     }
 
     $chain_opt = $chaincert ? {