WIP - feature completeness with 2.1.5 #223
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
October 20, 2020 16:59
…tification_mail in template
…nitialized or not
|
@ghoneycutt could you do a first review, now that all checks are passing? Thanks. |
added 7 commits
October 22, 2020 13:19
…notify is an reserved metaparam from puppet.
bastelfreak
reviewed
Oct 24, 2020
| $smtp_alert = undef, | ||
| $nopreempt = undef, | ||
| Boolean $global_tracking = false, | ||
| Variant[String, Array[String], Undef] $track_interface = undef, |
There was a problem hiding this comment.
the diff in this PR is quite huge? Do you think it's possible to cherry-pick the new datatypes for existing parameters into a single PR that we review first? Also I think 99% of those variables, if not all, should not allow empty strings. Could you update those to String[1] instead of String?
kenyon
changed the title
|
Will this get done any time soon? Debian Bullseye will be shipped with 2.1.5 . |
|
@sprd-bena hey, any chance that you can rebase this against our latest master branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
feature-completness-with-2.1.5 tries to make puppet-keealived feature complete in a sense that all options keepalievd 2.1.5 provides, can be set via this puppet module.
This Pull Request (PR) fixes the following issues
Currently a lot of options are missing :/
State of the Pull Request
This is currently and at the moment Work In Progress. I just wanted to push early to have the change to get early feedback, too.
So far
global_defsshould be completely covered. Only a few options are missing inspec. Anyone reading this is invited to give me a pair of eyes and provide some hints how to cover the missing ones!I had a talk with @ghoneycutt and he gave me the /ok/ to just do a large commit, as I do not change features, but just adding new options. As you can see in
global_defssome options are now set toundefas they only reflect the implicit default state of keepalived. I'm not quiet sure if this is just some old stuff or if keepalived actually switched that in the last 3(?) years...In the next days I want to try to do the same with
vrrp_instance. As I have no clue about LVS, I will quietly ignore this for now. I maybe will continue withvrrp_scriptthen...Anyway I have some "questions" aka I'm unsure about it, and like to get feedback:
paramsofglobal_defsto have a Data Type; I tried to reflect documentation from keepaliveds manpage as good as I could. Could someone have a look and give me a "go ahead"/continue or a "please stop and do it that way"?nftables: it could be just set, (with puppet viatrue, but in the config without parameter) and it could also have one parameter or two, if the user wants to specify the chain.Closing note for now:
I've ordered all options as they appear in keepaliveds documentation to make it easier to compare the state of "feature completeness".
Thanks.