Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sorry_server_lvs_method #150

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mattmix
Copy link

@mattmix mattmix commented Feb 23, 2019

This option is available in more recent versions of keepalived.

$real_servers = undef,
$sorry_server = undef,
$sorry_server_inhibit = false,
$sorry_server_lvs_method = undef,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a datatype for the new parameter

@@ -38,6 +38,9 @@ virtual_server <%= @ip_address %> <%= @port %> {
<%- if @sorry_server_inhibit -%>
sorry_server_inhibit
<%- end -%>
<%- if @sorry_server_lvs_method -%>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add a unit test to verify that this works?

@bastelfreak
Copy link
Member

Hi @mattmix, thanks for the PR! Can you please take a look at the inline comments I made?

@pccibot
Copy link

pccibot commented Sep 26, 2019

Dear @mattmix, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @mattmix, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @mattmix, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants