Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing http redirection to allow certbot automatic renewal #96

Merged
merged 3 commits into from
May 13, 2024

Conversation

amaldonadomat
Copy link
Contributor

@amaldonadomat amaldonadomat commented May 2, 2024

We've had http redirection for a while now. I'm removing the redirection so we can use the certbot autorenewal process (needs port 80 free) to reduce manual steps. I believe by now people should be used to the https.

Let me know if you don't agree with this, other options are:

  • Manually stop, renew and re-deploy every three months
  • Use complicated prehooks and posthooks (we need to add some secrets here to the deployment)
  • Another GHA workflow to do this, since we already have the secrets, maybe a cronjob that runs every 2 weeks and restarts the service

On top of that I've added an automatic re-deployment every month (cron) so it takes the new certificate if it's been generated, and added a step to cleanup docker resources so it doesn't use all the space on the instance

@amaldonadomat amaldonadomat changed the title removing http redirection to allow certbot renewal Removing http redirection to allow certbot automatic renewal May 2, 2024
@amaldonadomat amaldonadomat marked this pull request as ready for review May 2, 2024 06:20
Copy link
Contributor

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe by now people should be used to the https.

💯 Sounds good thanks!

@amaldonadomat amaldonadomat merged commit 4be2fb7 into main May 13, 2024
8 of 9 checks passed
@amaldonadomat amaldonadomat deleted the remove-http-redirection branch May 13, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants