fix: wait before shareable link is loaded

voltrondata · Jul 16, 2023 · a5ab93c · a5ab93c
1 parent b0f1606
commit a5ab93c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 16 deletions.
diff --git a/.github/workflows/test_client_e2e.yaml b/.github/workflows/test_client_e2e.yaml
@@ -69,12 +69,6 @@ jobs:
         start: npm run preview
         browser: chrome
 
-    - name: Upload Cypress chrome-run video artifact
-      if: always()
-      uses: actions/upload-artifact@v2
-      with:
-        name: Cypress video
-        path: /home/runner/work/substrait-fiddle/substrait-fiddle/client/cypress/videos/shareable.cy.js.mp4
 
   edge-run:
     runs-on: ubuntu-latest
@@ -105,10 +99,3 @@ jobs:
         build: npm run build
         start: npm run preview
         browser: edge
-
-    - name: Upload Cypress edge-run video artifact
-      if: always()
-      uses: actions/upload-artifact@v2
-      with:
-        name: Cypress video
-        path: /home/runner/work/substrait-fiddle/substrait-fiddle/client/cypress/videos/shareable.cy.js.mp4
diff --git a/client/cypress/e2e/shareable.cy.js b/client/cypress/e2e/shareable.cy.js
@@ -30,9 +30,11 @@ describe("Substrait Fiddle Shareable Link test", () => {
         return link;
       }).then((link) => {
         cy.visit(link);
-        cy.get("#editor").should("not.be.empty")
-        cy.contains(".multiselect__tag", "1002").should("exist");
-        cy.contains(".multiselect__tag", "2001").should("exist");
+        cy.wait(5000).then(()=>{
+          cy.get("#editor").should("not.be.empty")
+          cy.contains(".multiselect__tag", "1002").should("exist");
+          cy.contains(".multiselect__tag", "2001").should("exist");
+        });  
     });
     });
   });