Prompt before open_voila. #632
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prompt before open_voila to avoid accidentally trigger voila button. Because some temporary cells would contain commands such as "!rm file.csv", thus executing all cells would cause data loss.
|
looks like the check failure is irrelevant to the modification of voila/static/extension.js . |
|
Thanks @cailiang9. It would be nice to still stay one click away from the voila dashboard for the users who don't want the modal. Maybe the modal should show a "Do not ask again" checkbox? Or be made configurable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompt before open_voila to avoid accidentally trigger voila button.
Because some temporary cells would contain commands such as "!rm file.csv", thus executing all cells would cause data loss.