Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import for jupyter_server 1 #1359

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Fix import for jupyter_server 1 #1359

merged 4 commits into from
Jul 31, 2023

Conversation

martinRenou
Copy link
Member

No description provided.

@martinRenou martinRenou added the bug Something isn't working label Jul 31, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/voila/fix_import_server1

@martinRenou
Copy link
Member Author

We are supposed to test jupyter server 1, let's investigate the CI

@martinRenou
Force jupyter server version on CI
787e93d 
JupyterLab 4 being a build requirement, jupyter server 2 gets pulled. We
need to pin jupyter server for the test runtime.
@martinRenou
Fix name error server 1
f6fd6e1
@martinRenou
Fix import
a64314a
@martinRenou martinRenou marked this pull request as ready for review July 31, 2023 08:43
@martinRenou martinRenou merged commit 8f34f68 into voila-dashboards:0.4.x Jul 31, 2023
14 of 20 checks passed
@martinRenou martinRenou deleted the fix_import_server1 branch July 31, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martinRenou