-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BinderHub as a backend #83
Comments
Sounds good to me. Can different voila gallery entries use the same repo? Then you could perform two optimisations:
|
I am +1 on this plan. This all sounds really reasonable. Quick note on the hosting on github pages, since voila-dashboards.github.io is already used for the team compass, we may want to use voila-gallery.github.io instead. |
Do we want to only allow for one version of a binder to be on the gallery? (i.e. should people be able to update the ref for an accepted dashboard without approval from the gallery maintainers) |
Thanks @betatim for your input!
Yes they can.
Reusing binders sounds like a great idea. And indeed we get much faster launch times (since there is nothing to launch). But that also means keeping track of the url and the token? And making sure that binder is up before redirecting. |
I was under the impression that GitHub handles the redirect like this:
Would need to double check that. Otherwise happy to use
But if they update the ref, that means the gallery should point to the new one? It would be great if they could update it independently yes. We would need to make sure the binder is built before exposing it in the gallery though. |
For the transition, instead of just moving the POC repo, we should extract the files that we need, so we keep the git history and the contributors are still credited in the new repo. |
TLDR: It would be great for the Voila Gallery to use a BinderHub (mybinder.org) as a backend.
BinderHub as a backend for the gallery
The proposal is as follows:
Demo
Here is a repo that already implements this idea. The end result is relatively simple and minimal:
Why
It's simpler, and simpler to operate.
This would fix #57, #55, #31, potentially #49 and close voila-gallery/voila-gallery.org-deploy#1.
For #21, we would make
voila-gallery.org
point tovoila-dashboards.github.io
and add aCNAME
file that containsvoila-gallery.org
.Also since making the example work on Binder is part of the steps to add it to the gallery, it sounds reasonable to launch that Binder image directly.
TLJH plugin
We can keep the TLJH plugin for the users who want to deploy the gallery on their own on a single machine using TLJH.
This proposed change is for the public facing gallery, with mybinder.org as the BinderHub. But the BinderHub host could technically be changed to something else in the config.
The repo for the public facing gallery would be https://github.com/voila-dashboards/voila-gallery.org and the content would be the same as https://github.com/jtpio/voila-gallery-binderhub.
The current repo would be renamed to https://voila-dashboards/tljh-voila-gallery, and the
gallery.yaml
simplified (less examples). Thetljh_voila_gallery
package could also be published to pypi.org.Adding a new example
Pretty much the same as before:
ref
(trigger a build otherwise)Pros
Cons
Transition
Here are the steps to transition voila-gallery.org to this setup:
CNAME
voila-gallery.org
DNS entry tovoila-dashboards.github.io
I would be happy to hear other opinions on this proposal!
cc @pbugnion @yuvipanda @SylvainCorlay
Also pinging @betatim since it's related to mybinder.org (event though this is not a lot of traffic)
The text was updated successfully, but these errors were encountered: