Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password recovery flow #831

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Password recovery flow #831

merged 4 commits into from
Nov 13, 2024

Conversation

elboletaire
Copy link
Member

@elboletaire elboletaire commented Nov 7, 2024

Closes vocdoni/interoperability#200

  • Renamed some components for consistency
  • Changed forgot route to account/password to reuse it for the reset (via account/password/reset)
  • Edited the ForgotPasswordForm component to properly make expected API calls
  • Created new ResetPasswordForm component to handle the password reset behavior
  • Added optional email param to signin form to autofill it when trying to recover your password
  • Created elements for both password reset and password forgot, moving the expected logic there
  • Done the same for SignIn (creating elements/account/signin)
  • InputBasic was not accepting additional props
  • Added required routes

Copy link

github-actions bot commented Nov 7, 2024

@github-actions github-actions bot temporarily deployed to pull request November 7, 2024 16:39 Inactive
Copy link

github-actions bot commented Nov 7, 2024

@github-actions github-actions bot temporarily deployed to pull request November 7, 2024 16:39 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 7, 2024 16:42 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 7, 2024 16:42 Inactive
@elboletaire elboletaire changed the title WIP password recovery flow Password recovery flow Nov 8, 2024
@elboletaire elboletaire marked this pull request as ready for review November 8, 2024 15:17
@github-actions github-actions bot temporarily deployed to pull request November 8, 2024 15:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 8, 2024 15:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 12, 2024 12:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 12, 2024 12:10 Inactive
Copy link
Member

@emmdim emmdim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested e2e and seems to work properly.
Left some minor comments

@github-actions github-actions bot temporarily deployed to pull request November 12, 2024 14:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 12, 2024 14:47 Inactive
- Renamed some components for consistency
- Changed forgot route to `account/password` to reuse it for the reset
  (via `account/password/reset`)
- Edited the ForgotPasswordForm component to properly make expected API
  calls
- Created new ResetPasswordForm component to handle the password reset
  behavior
- Added optional email param to signin form to autofill it when trying to
  recover your password
- Created elements for both password reset and password forgot, moving
  the expected logic there
- Done the same for SignIn (creating elements/account/signin)
- InputBasic was not accepting additional props
- Added required routes

Pending: error handling
@github-actions github-actions bot temporarily deployed to pull request November 13, 2024 12:30 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 13, 2024 12:31 Inactive
@elboletaire elboletaire merged commit fcd923b into develop Nov 13, 2024
3 checks passed
@elboletaire elboletaire deleted the f/password-recovery branch November 13, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password Recovery
2 participants