-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Password recovery flow #831
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elboletaire
force-pushed
the
f/password-recovery
branch
from
November 7, 2024 16:40
194abd5
to
52c16f4
Compare
elboletaire
force-pushed
the
f/password-recovery
branch
from
November 8, 2024 15:16
52c16f4
to
c81f7d9
Compare
7 tasks
elboletaire
force-pushed
the
f/password-recovery
branch
from
November 12, 2024 12:08
c81f7d9
to
0358809
Compare
emmdim
reviewed
Nov 12, 2024
emmdim
reviewed
Nov 12, 2024
emmdim
reviewed
Nov 12, 2024
emmdim
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested e2e and seems to work properly.
Left some minor comments
- Renamed some components for consistency - Changed forgot route to `account/password` to reuse it for the reset (via `account/password/reset`) - Edited the ForgotPasswordForm component to properly make expected API calls - Created new ResetPasswordForm component to handle the password reset behavior - Added optional email param to signin form to autofill it when trying to recover your password - Created elements for both password reset and password forgot, moving the expected logic there - Done the same for SignIn (creating elements/account/signin) - InputBasic was not accepting additional props - Added required routes Pending: error handling
elboletaire
force-pushed
the
f/password-recovery
branch
from
November 13, 2024 12:29
63b976b
to
6f26fe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes vocdoni/interoperability#200
account/password
to reuse it for the reset (viaaccount/password/reset
)