fix recursive pagination bug #482
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Proud <[email protected]>
|
@kaushiklele Can you review please. Let me know if you have any questions and we can talk on VMware Slack. |
laidbackware
changed the title
|
@laidbackware, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Matt Proud <[email protected]>
laidbackware
force-pushed
the
pagination-fix
branch
from
250a2b8
to
98b1a4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current pagination implementation doesn't work due to a recursive loop bug that was created in PR #469.
The request function contains a while loop which calls itself, triggers the while loop, and on and on.
The only way to implement correctly is to wrap the request function and have the while loop run outside of the request function.
This fix should be back ported to all legacy branches as it is version agnostic.