Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Ignore zshippable in minor version during upgrade #4378

Closed

Commits on Feb 14, 2023

  1. Ignore zshippable in minor version during upgrade

    During dev testing of cluster upgrade functionality,
    some  of the package versions will have the postfix "-zshippable".
    
    The libraries used to compare versions of packages during upgrade
    look at a version string like "0.12.1+vmware.2-tkg.2-zshippable",
    and assume the minor version, "2-zshippable", is a non-number.
    
    The libraries also look at a version string like "0.12.1+vmware.2-tkg.3",
    and assume the minor version "3" is a number.
    
    The problem comes about because the same libraries see a non-number
    minor version as newer than any number version.
    So the version 0.12.1+vmware.2-tkg.2-zshippable is newer than
    0.12.1+vmware.2-tkg.3, which is incorrect
    
    To allow for dev testing to proceed we remove the "-zshippable" postfix
    right before the version strings are compared.
    Adolfo Duarte committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    c8c4d34 View commit details
    Browse the repository at this point in the history