Make Truncate method in TestHelper accept structs #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeyhun
force-pushed
the
test-helper-truncate
branch
from
61abe92
to
7a6f981
Compare
Modified the signature of Truncate method in TestHelper interface, making it accept structs rather than DB table names as strings.
jeyhun
force-pushed
the
test-helper-truncate
branch
from
7a6f981
to
4139eb8
Compare
| HasTable(tableName string) (bool, error) // Checks if DB table exists | ||
| DropTables(records ...Record) error // Drop DB tables by records | ||
| Truncate(records ...Record) error // Truncates DB tables | ||
| HasTable(tableName string) (bool, error) // Checks if DB table exists |
There was a problem hiding this comment.
@jeyhun please be consistent with interface either we support both tableName and records or just records. I don't want the refactors keep pouring in. You could have the following interface if it makes sense,
DropTables(records ...Record)
DropTablesByName(names ...string)
Please stick to this signature if you are refactoring. Note this would have repercussions once consumers upgrade the library. So it would be better to finalize and make change, else just leave it to callers.
krishnamiriyala
approved these changes
Sep 19, 2023
krishnamiriyala
previously approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the signature of
Truncatemethod inTestHelperinterface, making it accept structs rather than DB table names as strings.