-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop printing Protobuf message and its metadata in logs #52
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
- Coverage 70.56% 70.47% -0.10%
==========================================
Files 12 12
Lines 1410 1419 +9
==========================================
+ Hits 995 1000 +5
- Misses 328 329 +1
- Partials 87 90 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
7a32f03
to
ca5a03a
Compare
@jeyhun If it is used in logging add sample log for reference |
Added String() method to ProtoStoreMsg, which will print out only ID, org. ID, instance ID, revision, and table name.
ca5a03a
to
ba049e5
Compare
I've changed the PR's description to include a string version of an error generated by ProtoStore, which will include the JSON. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets fix the example for readability separately.
Added
String()
method toProtoStoreMsg
, which will print out only ID, org. ID, instance ID, revision, and table name.Before:
After:
This resolves issue #42