Print DB name in error logs #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeyhun
force-pushed
the
print-DB-name-with-errors
branch
2 times, most recently
from
4f8cd81
to
07c2925
Compare
jeyhun
commented
Jul 26, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
- Coverage 70.72% 70.56% -0.16%
==========================================
Files 12 12
Lines 1404 1410 +6
==========================================
+ Hits 993 995 +2
- Misses 324 328 +4
Partials 87 87
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jeyhun
commented
Jul 26, 2023
|
@jgafarov can you please update the commit message with sample logs from unit-tests or real setup? |
jeyhun
force-pushed
the
print-DB-name-with-errors
branch
from
07c2925
to
66ad890
Compare
Ok, added |
Started including database name in all errors Sample error log: SQL statement could not be executed [dbName=testcrud] ERROR: relation "xxxxxx" does not exist (SQLSTATE 42P01)
jeyhun
force-pushed
the
print-DB-name-with-errors
branch
from
66ad890
to
b450214
Compare
|
Lgtm |
krishnamiriyala
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started including database name in all errors
Sample error log: