-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support context based transaction for create/update only #48
Conversation
I'd like to see new/existing unit tests use the new code, in order to be able to see how it works in action and step through the code with a debugger. Right now no unit test touches the line |
@gaurav-vmware overall looks good to me, add unit-tests and remove unused code. |
bdfda3e
to
1c8ed04
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
- Coverage 70.42% 70.33% -0.10%
==========================================
Files 12 13 +1
Lines 1454 1483 +29
==========================================
+ Hits 1024 1043 +19
- Misses 337 347 +10
Partials 93 93
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1c8ed04
to
a386dde
Compare
…thods - Currently transaction support is only available create/upsert methods. - Update/Delete/Find still doesn't support them due to chaining of the where clauses
a386dde
to
da43b12
Compare
MR details -
Changes for exposing transactions outside datastore CRUD methods.
where clauses
Git issue link - #49 (comment)