Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a warning when there are no images to annotate #33

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

alemorcuq
Copy link
Contributor

@alemorcuq alemorcuq commented Jan 11, 2024

  • When there are images:
➜ ./bin/dt charts annotate $CHARTS/wordpress
 πŸŽ‰  Helm chart annotated successfully
  • When there are no images:
➜ ./bin/dt charts annotate $CHARTS/common
 ⚠️  No container images found to be annotated

- When there are images:

```
➜ ./bin/dt charts annotate $CHARTS/wordpress
 πŸŽ‰  Helm chart annotated successfully
```

- When there are no images:

```
➜ ./bin/dt charts annotate $CHARTS/common
 ⚠️  No container images found to be annotated
```
@alemorcuq alemorcuq changed the title Show the number of images when annotating a chart Show a warning when there are no images to annotate Jan 12, 2024
Copy link
Contributor

@juamedgod juamedgod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juamedgod juamedgod merged commit 597660d into main Jan 12, 2024
1 check passed
@juamedgod juamedgod deleted the num-annotations-message branch January 12, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants