Support customizing the images-dir in images pull/push commands #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpermar
reviewed
Dec 27, 2023
| @@ -103,5 +107,7 @@ func newPullCommand() *cobra.Command { | |||
| }, | |||
| } | |||
| cmd.PersistentFlags().StringVar(&outputFile, "output-file", outputFile, "generate a tar.gz with the output of the pull operation") | |||
| cmd.PersistentFlags().StringVar(&imagesDir, "images-dir", imagesDir, | |||
| "directory where the images will be pulled to. If not empty, it overrides the default images directory inside the chart directory") | |||
There was a problem hiding this comment.
Is this description accurate? I thought the images folder was now outside the chart directory after the refactoring recently done.
There was a problem hiding this comment.
This only applies to the pull/push commands, where there is no concept of wrap bundle, so the images are still placed in the chart dir. The refactoring was for the wrap/unwrap, where we control the format of the bundle.
There was a problem hiding this comment.
Ah, right I recall it now. I guess it makes sense. I wonder if the images-dir should be mandatory. Anyways, users will tell. Looks good then.
mpermar
reviewed
Dec 27, 2023
| @@ -79,4 +82,7 @@ func newPushCmd() *cobra.Command { | |||
| return nil | |||
| }, | |||
| } | |||
| cmd.PersistentFlags().StringVar(&imagesDir, "images-dir", imagesDir, | |||
| "directory containing the images to push. If not empty, it overrides the default images directory inside the chart directory") | |||
mpermar
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.