-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support customizing the images-dir in images pull/push commands #31
Conversation
@@ -103,5 +107,7 @@ func newPullCommand() *cobra.Command { | |||
}, | |||
} | |||
cmd.PersistentFlags().StringVar(&outputFile, "output-file", outputFile, "generate a tar.gz with the output of the pull operation") | |||
cmd.PersistentFlags().StringVar(&imagesDir, "images-dir", imagesDir, | |||
"directory where the images will be pulled to. If not empty, it overrides the default images directory inside the chart directory") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this description accurate? I thought the images folder was now outside the chart directory after the refactoring recently done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only applies to the pull/push commands, where there is no concept of wrap bundle, so the images are still placed in the chart dir. The refactoring was for the wrap/unwrap, where we control the format of the bundle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right I recall it now. I guess it makes sense. I wonder if the images-dir should be mandatory. Anyways, users will tell. Looks good then.
@@ -79,4 +82,7 @@ func newPushCmd() *cobra.Command { | |||
return nil | |||
}, | |||
} | |||
cmd.PersistentFlags().StringVar(&imagesDir, "images-dir", imagesDir, | |||
"directory containing the images to push. If not empty, it overrides the default images directory inside the chart directory") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same response :)
No description provided.