Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Commit

Permalink
Update to use slf4j2 (#38)
Browse files Browse the repository at this point in the history
The latest dependency update didn't completely switch all of the
dependencies correctly for the SLF4J v2 update.

Also, clean up some Java complier warnings about deprecated language features.
  • Loading branch information
gmcelhoe authored Jan 24, 2024
1 parent 068edd0 commit 505c9dc
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j-impl</artifactId>
<artifactId>log4j-slf4j2-impl</artifactId>
<version>2.22.1</version>
<scope>test</scope>
</dependency>
Expand Down Expand Up @@ -265,7 +265,7 @@
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<version>0.8.8</version>
<version>0.8.11</version>
<executions>
<execution>
<goals>
Expand Down
2 changes: 1 addition & 1 deletion test-operations/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j-impl</artifactId>
<artifactId>log4j-slf4j2-impl</artifactId>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ public class OperationTest {

@Test
public void utilityClassIsWellFormed() throws Exception {
Constructor[] ctors = Operations.class.getDeclaredConstructors();
Constructor<?>[] ctors = Operations.class.getDeclaredConstructors();
Assert.assertEquals("Utility class should only have one constructor",
1, ctors.length);
Constructor ctor = ctors[0];
Constructor<?> ctor = ctors[0];
Assert.assertFalse("Utility class constructor should be inaccessible",
ctor.isAccessible());
ctor.setAccessible(true); // obviously we'd never do this in production
ctor.canAccess(null));
ctor.setAccessible(true); // obviously we'd never do this outside of tests
Assert.assertEquals("You'd expect the construct to return the expected type",
Operations.class, ctor.newInstance().getClass());
}
Expand Down
2 changes: 1 addition & 1 deletion test-utilities/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j-impl</artifactId>
<artifactId>log4j-slf4j2-impl</artifactId>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down

0 comments on commit 505c9dc

Please sign in to comment.