This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Add authentication via API token #226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for authentication with API tokens as described in [Generate an API Access Token][1]. The authentication follows RFC6749 (OAuth 2.0). If the user is set to 'API_TOKEN' the password is interpreted as token string and instead of setting the login credentials of the pyvcloud client, the client's rehydrate_from_token function is called with the optional argument is_jwt_token=True. [1]: https://docs.vmware.com/en/VMware-Cloud-Director/10.3/VMware-Cloud-Director-Tenant-Portal-Guide/GUID-A1B3B2FA-7B2C-4EE1-9D1B-188BE703EEDE.html Signed-off-by: Martin Fleischer <[email protected]>
bvoilar
force-pushed
the
Add-api-token-authentication
branch
from
3f4fa8a
to
9ce8de8
Compare
ruupert
reviewed
Jan 5, 2024
| @@ -43,7 +44,15 @@ def login(self): | |||
| api_version=api_version, | |||
| verify_ssl_certs=verify_ssl_certs) | |||
|
|
|||
| self.client.set_credentials(BasicLoginCredentials(user, org, password)) | |||
| if user == 'API_TOKEN': | |||
| oAuthResponse = post( | |||
There was a problem hiding this comment.
might want to pass verify=verify_ssl_certs as option to post() so that in case someone says verify_ssl_certs: False in their tasks it would do as it is supposed to
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for authentication using API Access Tokens. The authentication follows RFC6749 (OAuth 2.0). This is useful if an external identity provider is configured for authentication with vCloud Director.
If
useris set to "API_TOKEN" thepasswordis interpreted as token and instead of setting the login credentials of the pyvcloud client, the client'srehydrate_from_tokenfunction is called with the token and the optional argumentis_jwt_token=True.Implements: #223
Usage