analyzer: merge creation of vtmp directory for check-updates/up comma…

…nds (#126)

src/check-updates.v

@@ -1,13 +1,8 @@
 module main
 
 import cli
-import os
 
 fn check_updates_cmd(_ cli.Command) ! {
-	if !os.exists(analyzer_dir) {
-		os.mkdir(analyzer_dir)!
-	}
-
 	download_install_vsh()!
 	call_install_vsh('check-updates')!
 }

src/up.v

@@ -4,15 +4,10 @@ import cli
 import term
 import os
 
-pub const analyzer_dir = os.join_path(os.vtmp_dir(), 'v-analyzer')
 pub const analyzer_install_script_download_path = 'https://raw.githubusercontent.com/vlang/v-analyzer/main/install.vsh'
-pub const analyzer_install_script_path = os.join_path(analyzer_dir, 'install.vsh')
+pub const analyzer_install_script_path = os.join_path(os.vtmp_dir(), 'v-analyzer', 'install.vsh')
 
 fn up_cmd(cmd cli.Command) ! {
-	if !os.exists(analyzer_dir) {
-		os.mkdir(analyzer_dir)!
-	}
-
 	download_install_vsh()!
 
 	is_nightly := cmd.flags.get_bool('nightly') or { false }

src/utils.v

@@ -21,6 +21,11 @@ pub fn successln(msg string) {
 }
 
 pub fn download_install_vsh() ! {
+	download_dir := os.join_path(os.vtmp_dir(), 'v-analyzer')
+	if !os.exists(download_dir) {
+		os.mkdir(download_dir) or { return error('Failed to create tmp dir: ${err}') }
+	}
+
 	http.download_file(analyzer_install_script_download_path, analyzer_install_script_path) or {
 		return error('Failed to download script: ${err}')
 	}