Support shortest possible finnish reference number in international format. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormat. A finnish reference number is at least 4 digits, but as I see it the spec doesn't prohibit the first numbers being zero. The smallest non-zero finnish reference would thus be 0013. The rules for converting finnish reference number to international "Creditor Reference" RF format also state that initial zeroes should be removed before embedding, thus yielding RF41 13 as the shortest finnish refernce in RF format (rather than RF41 0013). Thus this commit updates the regex to allow for a minimum of RF + 4 digits instead of RF + 6 digits. See http://www.finanssiala.fi/maksujenvalitys/dokumentit/kansainvalisen_viitteen_rakenneohje.pdf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A finnish reference number is at least 4 digits, but as I see it the spec doesn't prohibit the first numbers being zero. The smallest non-zero finnish reference would thus be 0013. The rules for converting finnish reference number to international "Creditor Reference" RF format also state that initial zeroes should be removed before embedding, thus yielding RF41 13 as the shortest finnish refernce in RF format (rather than RF41 0013). Thus this PR updates the regex to allow for a minimum of RF + 4 digits instead of RF + 6 digits.
See http://www.finanssiala.fi/maksujenvalitys/dokumentit/kansainvalisen_viitteen_rakenneohje.pdf