Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync method market.edit with actual api version #1584

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Sync method market.edit with actual api version #1584

merged 2 commits into from
Sep 11, 2023

Conversation

Rahovski
Copy link
Contributor

List of changes

  • added fields video_ids, variant_ids, is_main_variant to MarketProductParams model
  • Rebuild order of argumets in method edit according api documentation

Warning

Cannot add test data for this method, cause need to have market with admin rights

Sources

Source of method

Bound with issue #1222

@Rahovski Rahovski temporarily deployed to VkNet August 28, 2023 20:57 — with GitHub Actions Inactive
@Rahovski
Copy link
Contributor Author

Rahovski commented Sep 2, 2023

@inyutin-maxim Please, need review

@inyutin-maxim inyutin-maxim added the Pull Request Исправление внесенное пользователем не состоящим в основном списке разработчиков label Sep 11, 2023
@inyutin-maxim inyutin-maxim added this to the v1.76.0 milestone Sep 11, 2023
@inyutin-maxim inyutin-maxim temporarily deployed to VkNet September 11, 2023 08:21 — with GitHub Actions Inactive
@inyutin-maxim inyutin-maxim merged commit c0d25a6 into vknet:develop Sep 11, 2023
1 check passed
@Rahovski Rahovski mentioned this pull request Sep 11, 2023
Open
90 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inyutin-maxim inyutin-maxim inyutin-maxim approved these changes

Assignees

@Rahovski Rahovski

Labels
Pull Request Исправление внесенное пользователем не состоящим в основном списке разработчиков
Projects
None yet
Milestone
v1.76.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Rahovski @inyutin-maxim