Fixed coverage on Python>=3.11 #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess the change to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make test-covis not at 100% on Python>=3.11 when executed locally.Nothing is wrong with the pipeline as it is still using Python 3.9 but it is a minor incovenience during development.
It is due to the fact that the handling of
typing.Anybecomes unnecessary with this change in cpython: python/cpython#88690This PR resolves this situation by adding a quick UT that is not so useful for Python<3.11 but covers that specific
try-exceptblock.We may (or may not) also add support for Python>=3.11 in the coverage pipeline, in this PR or another one.