Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore support to do template-syntax lookups for nested dicts. #1174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnbergvall
Copy link
Contributor

This restores template syntax-lookup with nested dicts as input which were supported pre v1.0.

One caveat is that nested lookups (dict1.key) will return defaultdict default value, where single lookups (key) will return missing.

Also returning empty values for nested defaultdict is possible but would require a custom lookup function instead of using Django Variable.resolve(). However I think it's such an uncommon case that it does not motivate the extra maintenance

This patch skips the lookup for regular "single" key-access to not return default value from defaultdicts. Nested defaultdicts will however return the default value instead of "missing" due to how Django's Variable.resolve(key) works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant