Added filament to github workflow test

Allow getNavigationGroup to be null
visualbuilder · Aug 19, 2024 · 42308c2 · 42308c2
1 parent 37cc384
commit 42308c2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -11,10 +11,12 @@ jobs:
                 os: [ubuntu-latest]
                 php: [8.2]
                 laravel: [10.*]
+                filament: [3.*]
                 dependency-version: [ prefer-stable]
                 include:
                     -   laravel: 10.*
                         testbench: 8.*
+                        filament: 3.*
 
         name: P${{ matrix.php }} - L${{ matrix.laravel }} - ${{ matrix.dependency-version }}
 
@@ -36,8 +38,8 @@ jobs:
 
             -   name: Install dependencies
                 run: |
-                    composer require "laravel/framework:${{ matrix.laravel }}" "orchestra/testbench:${{ matrix.testbench }}" "nesbot/carbon:>=2.62.1" --no-interaction --no-update
-                    composer update --${{ matrix.dependency-version }} --prefer-dist --no-interaction
+                    composer require "laravel/framework:${{ matrix.laravel }}" "orchestra/testbench:${{ matrix.testbench }}" "filament/filament:${{ matrix.filament }}" --no-interaction --no-update
+                    composer update --${{ matrix.stability }} --prefer-dist --no-interaction
 
             -   name: Setup Problem Matches
                 run: |

diff --git a/src/EmailTemplatesPlugin.php b/src/EmailTemplatesPlugin.php
@@ -32,7 +32,7 @@ public function navigationGroup($navigationGroup): static
         return $this;
     }
 
-    public function getNavigationGroup(): string
+    public function getNavigationGroup(): ?string
     {
         return $this->navigationGroup ?? config('filament-email-templates.navigation.templates.group');
     }